During memory hotplug testing, I got the following warning:

ERROR: Bad of_node_put() on /memory@0

of_node_release
kref_put
of_node_put
of_find_node_by_type
hot_add_node_scn_to_nid
hot_add_scn_to_nid
memory_add_physaddr_to_nid
...


of_find_node_by_type() loop does of_node_put for us so remove the
duplicate one inside the loop.

Signed-off-by: Anton Blanchard <an...@samba.org>
Cc: sta...@kernel.org
---

Index: linux-powerpc/arch/powerpc/mm/numa.c
===================================================================
--- linux-powerpc.orig/arch/powerpc/mm/numa.c   2011-06-06 08:07:35.148708089 
+1000
+++ linux-powerpc/arch/powerpc/mm/numa.c        2011-08-10 11:31:59.723379868 
+1000
@@ -1214,7 +1214,6 @@ int hot_add_node_scn_to_nid(unsigned lon
                        break;
                }
 
-               of_node_put(memory);
                if (nid >= 0)
                        break;
        }


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to