On Thu, 2011-08-11 at 19:32 +0200, Andre Heider wrote: > On Thu, Aug 11, 2011 at 2:13 PM, Arnd Bergmann <a...@arndb.de> wrote: > > On Thursday 04 August 2011, Geoff Levand wrote: > >> > + * > >> > + * udbg debug output routine via GELIC UDP broadcasts > >> > + * Copyright (C) 2010 Hector Martin <hec...@marcansoft.com> > >> > + * Copyright (C) 2011 Andre Heider <a.hei...@gmail.com> > >> > >> Some of this seems to be taken from the gelic driver, so shouldn't > >> the copyright info from there be included here? > > > > Moreover, if there is a significant amount of code duplication > > between this driver and gelic, I would expect to actually share > > the code instead, either by integrating the udbg code into the > > gelic driver in form of netconsole support, or by moving the > > common parts into a separate module. > > No, thankfully there is no significant code duplication :) > It contains a few structs and defines found elsewhere, but that's > because it's not a real netdev. It just prepares the eth/ip/udp header > once for its single purpose, then uses the hypervisor to send and poll > - in contrast to the gelic driver, which reuses its irqhandler for > netconsole support.
Ack. As long as it's not enabled by default and understood to be what it is, ie, a tool to debug really early boot code before a more "proper" console is available, I have no objection. There is really no code dup, just a couple of struct definitions and it's not a big deal. I'll merge it. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev