On 11/04/2011 02:33 PM, Kumar Gala wrote: > > On Nov 4, 2011, at 12:33 PM, Scott Wood wrote: > >> On 11/04/2011 07:29 AM, Zhao Chenhui wrote: >>> From: Li Yang <le...@freescale.com> >>> >>> The timebase sync is not only necessary when using KEXEC. It should also >>> be used by normal boot up and cpu hotplug. Remove the ifdef added by >>> the KEXEC patch. >> >> The KEXEC patch didn't just add the ifdef, it also added the initializers: >> >>> @@ -105,8 +107,64 @@ smp_85xx_setup_cpu(int cpu_nr) >>> >>> struct smp_ops_t smp_85xx_ops = { >>> .kick_cpu = smp_85xx_kick_cpu, >>> +#ifdef CONFIG_KEXEC >>> + .give_timebase = smp_generic_give_timebase, >>> + .take_timebase = smp_generic_take_timebase, >>> +#endif >>> }; >> >> U-Boot synchronizes the timebase on 85xx. With what chip and U-Boot >> version are you seeing this not happen? >> >> If you are seeing only a small (around one tick) difference, make sure >> you're running a U-Boot that has this commit: [snip] > > Scott, > > Aren't we going to need this when a core is woken back up w/o any state?
We'll need some form of timebase resync if a core is individually hard-reset -- I was responding to the "should also be used by normal boot up" bit. For kexec/hotplug, if we must reset the core (for deep sleep we must), any reason not to do the sync the same way U-Boot does? -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev