On Thu, 2011-11-10 at 10:50 -0600, Timur Tabi wrote: > I'm not sure that Kconfig rule is enforceable. We use 'select' all the time > to make sure that our boards enable the options that need to be enabled. I'd > rather see this: > > config X > select A > > config Y > select A > > config Z > select A > > than this: > > config A > default y if X | Y | Z > > The former is more maintainable and does not allow the option of disabling > "A" if someone wants "X".
This is fine as long as config A is not a user selectable option. We do the wrong thing in a few places (i2c comes to mind) and we should most certainly consider fixing it. Some of the solution is to move some select's to defconfigs, some is to do things the way Kyle proposed. For PHYS_64BIT, I'm not 100% certain at this point what the best approach it. It should clearly be fixed and hidden for real 64-bit. As for the rest, should it be user selectable ? I tend to think it should be fixed & selected by the board config and keep it that way, avoiding the user question entirely... but you may have good reasons to want to keep it around. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
