Michael Neuling wrote: > Fix a bunch of compiler errors and warnings introduced in: > commit ddd3d905436b572ebadc09dcf2d12ca5b37020a0 > Author: Timur Tabi<ti...@freescale.com> > drivers/video: fsl-diu-fb: merge all allocated data into one block > > Signed-off-by: Michael Neuling<mi...@neuling.org> > --- > Timur: you do compile test your patches, right? :-P
I have a script that tests each commit in a set to make sure it compiles, so that git-bisect isn't broken. > This is effecting mpc85xx_defconfig on mainline (and has been in > linux-next for while already). > > diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c > index acf292b..78cac52 100644 > --- a/drivers/video/fsl-diu-fb.c > +++ b/drivers/video/fsl-diu-fb.c > @@ -366,7 +366,7 @@ struct mfb_info { > */ > struct fsl_diu_data { > dma_addr_t dma_addr; > - struct fb_info fsl_diu_info[NUM_AOIS]; > + struct fb_info *fsl_diu_info[NUM_AOIS]; This doesn't make any sense. If you change fsl_diu_info into a pointer, then where is the object being allocated? -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev