> +#ifdef CONFIG_QUICC_ENGINE > + np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic"); > + if (np) { > + qe_ic_init(np, 0, qe_ic_cascade_low_mpic, > + qe_ic_cascade_high_mpic); > + of_node_put(np); > + > + } else > + pr_err("Could not find qe-ic node\n");
Since you have to use pr_err instead of dev_err, please add a prefix to the message. Like this: pr_err("mpc85xx-rdb: could not find qe-ic node\n"); or maybe something like this: pr_err("%s: could not find qe-ic node\n", __func__); > + if (machine_is(p1025_rdb)) { > + > + __be32 __iomem *pmuxcr; > + > + np = of_find_node_by_name(NULL, "global-utilities"); > + > + if (np) { > + pmuxcr = of_iomap(np, 0) + MPC85xx_PMUXCR_OFFSET; Use the ccsr_guts_85xx structure instead of hard-coded offsets. MPC85xx_PMUXCR_OFFSET should be deleted. > + > + if (!pmuxcr) > + pr_err(KERN_EMERG "Error: Alternate function" > + " signal multiplex control register > not" > + " mapped!\n"); A missing node in the device tree is NOT an emergency. Also, the KERN_xxx macros are not supposed to be used in a pr_xxx macro. Please don't blindly copy/paste code from somewhere else without thinking about it. -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev