On Sat, Aug 11, 2012 at 08:19:43AM -0500, Tabi Timur-B04825 wrote: > On Tue, Aug 7, 2012 at 3:43 AM, Zhao Chenhui <chenhui.z...@freescale.com> > wrote: > > > +int mpc85xx_pmc_set_wake(struct device *dev, bool enable) > > +{ > > + int ret = 0; > > + struct device_node *clk_np; > > + const u32 *prop; > > + u32 pmcdr_mask; > > + > > + if (!pmc_regs) { > > + pr_err("%s: PMC is unavailable\n", __func__); > > You have a 'struct device', so please use dev_err instead. > > > + return -ENODEV; > > + } > > + > > + if (enable && !device_may_wakeup(dev)) > > + return -EINVAL; > > + > > + clk_np = of_parse_phandle(dev->of_node, "fsl,pmc-handle", 0); > > + if (!clk_np) > > + return -EINVAL; > > + > > + prop = of_get_property(clk_np, "fsl,pmcdr-mask", NULL); > > + if (!prop) { > > + ret = -EINVAL; > > + goto out; > > + } > > + pmcdr_mask = be32_to_cpup(prop); > > + > > + if (enable) > > + /* clear to enable clock in low power mode */ > > + clrbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + else > > + setbits32(&pmc_regs->pmcdr, pmcdr_mask); > > + > > +out: > > + of_node_put(clk_np); > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(mpc85xx_pmc_set_wake); > > Use EXPORT_SYMBOL, not EXPORT_SYMBOL_GPL. > > > + > > +/** > > + * mpc85xx_pmc_set_lossless_ethernet - enable lossless ethernet > > + * in (deep) sleep mode > > + * @enable: True to enable event generation; false to disable > > + */ > > +void mpc85xx_pmc_set_lossless_ethernet(int enable) > > Should this be 'bool enable'? > > > @@ -21,6 +22,17 @@ struct device_node; > > > > extern void fsl_rstcr_restart(char *cmd); > > > > +#ifdef CONFIG_FSL_PMC > > +extern int mpc85xx_pmc_set_wake(struct device *dev, bool enable); > > +extern void mpc85xx_pmc_set_lossless_ethernet(int enable); > > Don't use 'extern' for functions. >
Why? I think there is no difference. -Chenhui _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev