> On Fri, 2013-03-08 at 11:38 +0800, Chen Gang wrote:
> > originally I did not notice src buf len and dest buf len are the same.
> > so origianlly, it is not a bug issue, it is only for beautify code.
> > and now, using strcpy is better.
>
> Being the same len doesn't mean it's safe to use strcpy ... the source
> might be missing the 0 terminator. In this specific case though, I
> believe the source string comes was itself populated with strlcpy
> (at least since your patch 6b6680c4ea3952af8ae76915cbca41245147741b) so
> strcpy is indeed safe but using strlcpy doesn't hurt does it ?
Using strlcpy() also stops someone else having to check it
again in a few years time.
David
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
