Enhance PPC architecture specific code to use hotplug-safe iterators
to walk PCI buses.

Signed-off-by: Jiang Liu <jiang....@huawei.com>
Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
Cc: Paul Mackerras <pau...@samba.org>
Cc: Gavin Shan <sha...@linux.vnet.ibm.com>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: Grant Likely <grant.lik...@secretlab.ca>
Cc: Bill Pemberton <wf...@virginia.edu>
Cc: Yinghai Lu <ying...@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ker...@vger.kernel.org
---
 arch/powerpc/kernel/pci-common.c |  4 ++--
 arch/powerpc/kernel/pci_64.c     | 22 ++++++++--------------
 2 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c
index f5c5c90..56ad3a4 100644
--- a/arch/powerpc/kernel/pci-common.c
+++ b/arch/powerpc/kernel/pci-common.c
@@ -1386,7 +1386,7 @@ void __init pcibios_resource_survey(void)
        struct pci_bus *b;
 
        /* Allocate and assign resources */
-       list_for_each_entry(b, &pci_root_buses, node)
+       for_each_pci_root_bus(b)
                pcibios_allocate_bus_resources(b);
        pcibios_allocate_resources(0);
        pcibios_allocate_resources(1);
@@ -1396,7 +1396,7 @@ void __init pcibios_resource_survey(void)
         * bus available resources to avoid allocating things on top of them
         */
        if (!pci_has_flag(PCI_PROBE_ONLY)) {
-               list_for_each_entry(b, &pci_root_buses, node)
+               for_each_pci_root_bus(b)
                        pcibios_reserve_legacy_regions(b);
        }
 
diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c
index 873050d..d71249b 100644
--- a/arch/powerpc/kernel/pci_64.c
+++ b/arch/powerpc/kernel/pci_64.c
@@ -207,10 +207,8 @@ void pcibios_setup_phb_io_space(struct pci_controller 
*hose)
 long sys_pciconfig_iobase(long which, unsigned long in_bus,
                          unsigned long in_devfn)
 {
-       struct pci_controller* hose;
-       struct list_head *ln;
-       struct pci_bus *bus = NULL;
-       struct device_node *hose_node;
+       struct pci_controller* hose = NULL;
+       struct pci_bus *bus;
 
        /* Argh ! Please forgive me for that hack, but that's the
         * simplest way to get existing XFree to not lockup on some
@@ -229,19 +227,15 @@ long sys_pciconfig_iobase(long which, unsigned long 
in_bus,
        /* That syscall isn't quite compatible with PCI domains, but it's
         * used on pre-domains setup. We return the first match
         */
-
-       for (ln = pci_root_buses.next; ln != &pci_root_buses; ln = ln->next) {
-               bus = pci_bus_b(ln);
-               if (in_bus >= bus->number && in_bus <= bus->busn_res.end)
+       for_each_pci_root_bus(bus)
+               if (in_bus >= bus->number && in_bus <= bus->busn_res.end) {
+                       hose = pci_bus_to_host(bus);
+                       pci_bus_put(bus);
                        break;
-               bus = NULL;
-       }
-       if (bus == NULL || bus->dev.of_node == NULL)
+               }
+       if (hose == NULL)
                return -ENODEV;
 
-       hose_node = bus->dev.of_node;
-       hose = PCI_DN(hose_node)->phb;
-
        switch (which) {
        case IOBASE_BRIDGE_NUMBER:
                return (long)hose->first_busno;
-- 
1.8.1.2

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to