On Tuesday, October 08, 2013 02:56:23 PM Michael Ellerman wrote: > On Thu, Oct 03, 2013 at 01:51:27PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Tuesday, October 01, 2013 04:13:25 PM Michael Ellerman wrote: > > > On Mon, Sep 30, 2013 at 03:11:42PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > __initdata tag should be placed between the variable name and equal > > > > sign for the variable to be placed in the intended .init.data section. > > > > > > I see lots of other occurences of that in arch/powerpc. Why not send a > > > single patch to update them all? > > > > The other occurences while not following the preferred kernel coding style > > are (probably) working OK with gcc. This particular occurence just doesn't > > work as it should. > > Why would the other occurrences work but not this one?
Because gcc seems to generate the correct code for things like i.e. this one: struct of_device_id __initdata legacy_serial_parents[] but not for ones like this: struct __initdata of_device_id legacy_serial_parents[] > Regardless, why don't we just do a single patch to clean them all up to > match coding style and (probably) do what they're intended. Because: - fixing this occurence changes runtime, fixing others won't - there were no such request from powerpc Maintainers Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
