Paul Gortmaker <[email protected]> writes: > On 14-01-28 12:28 PM, Aneesh Kumar K.V wrote: >> Paul Gortmaker <[email protected]> writes: >> >>> Commit b3084f4db3aeb991c507ca774337c7e7893ed04f ("powerpc/thp: Fix >>> crash on mremap") added a "typedef struct spinlock spinlock_t;" >>> which on gcc 4.5.2 (and possibly other versions) causes many of: >>> >>> include/linux/spinlock_types.h:76:3: error: redefinition of typedef >>> 'spinlock_t' >>> arch/powerpc/include/asm/pgtable-ppc64.h:563:25: note: previous declaration >>> of 'spinlock_t' was here >>> In file included from include/linux/mutex.h:15:0, >>> from include/linux/notifier.h:13, >>> from include/linux/pm_qos.h:8, >>> from include/linux/netdevice.h:28, >>> from drivers/net/wireless/ath/wil6210/wil6210.h:20, >>> from drivers/net/wireless/ath/wil6210/debug.c:17: >>> >>> It appears that somewhere between gcc 4.5.2 and 4.6.3 this >>> redefinition restriction was lifted. Using the proper header >>> from within !ASSEMBLY seems to fix it up in an acceptable way. >>> >>> Cc: Aneesh Kumar K.V <[email protected]> >>> Cc: Kirill A. Shutemov <[email protected]> >>> Cc: Benjamin Herrenschmidt <[email protected]> >>> Signed-off-by: Paul Gortmaker <[email protected]> >>> --- >>> >> >> >> http://mid.gmane.org/[email protected] >> >> This was posted earlier. > > I see. Well I guess Ben didn't use it since it is the same as the > temporary not-signed-off-by hack patch I posted earlier as well. > > https://lkml.org/lkml/2014/1/27/584 > > I believe what I've posted here below to be the proper fix.
I had another variant which needed this http://mid.gmane.org/1388999012-14424-1-git-send-email-aneesh.ku...@linux.vnet.ibm.com BTW I had added the above struct spinlock; patch as the backport to stable 3.13 series. So if we are picking another one, we may need to update stable also -aneesh _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
