On Wed, Feb 26, 2014 at 10:23:01AM +0800, Liu Ping Fan wrote: > The branch target should be the func addr, not the addr of func_descr_t. > So using ppc_function_entry() to generate the right target addr. > > Signed-off-by: Liu Ping Fan <pingf...@linux.vnet.ibm.com> > --- > This bug will make ftrace fail to work. It can be triggered when the kernel > size grows up. > --- > arch/powerpc/kernel/ftrace.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c > index 9b27b29..b0ded97 100644 > --- a/arch/powerpc/kernel/ftrace.c > +++ b/arch/powerpc/kernel/ftrace.c > @@ -74,6 +74,7 @@ ftrace_modify_code(unsigned long ip, unsigned int old, > unsigned int new) > */ > static int test_24bit_addr(unsigned long ip, unsigned long addr) > { > + addr = ppc_function_entry((void *)addr);
Won't this break on LE? _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev