On Fri, Mar 21, 2014 at 02:17:28PM +0530, Viresh Kumar wrote: > > +static ssize_t show_cpuinfo_nominal_freq(struct cpufreq_policy *policy, > > + char *buf) > > +{ > > + int nominal_freq; > > + nominal_freq = > > pstate_id_to_freq(powernv_pstate_info.pstate_nominal_id); > > + return sprintf(buf, "%u\n", nominal_freq); > > return sprintf(buf, "%u\n", > pstate_id_to_freq(powernv_pstate_info.pstate_nominal_id));
Sure. Will fix this. > > ?? > > > +} > > + > > + > > remove extra blank line. > > > +struct freq_attr cpufreq_freq_attr_cpuinfo_nominal_freq = { > > + .attr = { .name = "cpuinfo_nominal_freq", > > + .mode = 0444, > > + }, > > Align {} Probably the use of ATTR_RO(cpuinfo_nominal_freq) and renaming show_cpuinfo_nominal_freq to cpuinfo_nominal_freq_show() would be even better. What do you think ? > > > + .show = show_cpuinfo_nominal_freq, > > +}; > > + > > + > > static struct freq_attr *powernv_cpu_freq_attr[] = { > > &cpufreq_freq_attr_scaling_available_freqs, > > + &cpufreq_freq_attr_cpuinfo_nominal_freq, > > NULL, > > }; This needs to be rewritten to include the entries of cpufreq_generic_attr. > Thanks for the review. -- Regards gautham. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev