> -----Original Message----- > From: Wood Scott-B07421 > Sent: Wednesday, April 16, 2014 3:39 AM > To: Wang Dongsheng-B40534 > Cc: Jin Zhengxiong-R64188; [email protected]; Kushwaha Prabhakar-B32579; > [email protected] > Subject: Re: [PATCH v2 1/2] fsl/corenet_generic: add a particular > initialization > for platform > > On Tue, 2014-04-15 at 13:53 +0800, Dongsheng Wang wrote: > > From: Wang Dongsheng <[email protected]> > > > > Corenet_generic is a generic platform initialization. Those based on > > the corenet_generic board maybe need a particular initialize to > > enable/set some IP-Blocks. So add "Fix Generic Initialization" to solve > > this kind of special cases. > > I still don't understand what you mean by "fix". What are you fixing, > or what is fixed? > > There is no need for adding an infrastructure layer here. Just add a > new piece of code for t104x diu, and have it be called by an appropriate > initfunc. >
"fix" is means to handle some boards those based on corenet_generic config file, But those boards may need some special handle. Perhaps these used to handle special feature codes not have an appropriate initfunc we cannot *just find* an appropriate place, if more and more boards need to do this, at that time maybe *initfunc* looks very complicated. So we need this "fix" layer to deal them. We need a plan to fix those boards, not just find an initfunc. I thinks "fix" is the best initfunc to handle those special things. If "fix" is not clear, did you have a good idear? :) > > Signed-off-by: Wang Dongsheng <[email protected]> > > --- > > *v2* > > 1/ Split DIU code. > > 2/ make fix.c as a independent driver. > > diff --git a/arch/powerpc/platforms/85xx/Kconfig > b/arch/powerpc/platforms/85xx/Kconfig > > index c17aae8..fce2341 100644 > > --- a/arch/powerpc/platforms/85xx/Kconfig > > +++ b/arch/powerpc/platforms/85xx/Kconfig > > @@ -269,6 +269,17 @@ config CORENET_GENERIC > > The following boards are supported for both 32bit and 64bit kernel: > > P5020 DS and P5040 DS > > > > +config FIX_GENERIC_PLATFORM_INIT > > + bool "Fix Generic Initialization" > > + depends on CORENET_GENERIC > > Why does this depend on CORENET_GENERIC? > Because CORENET_GENERIC is a multiboards file, This is designed to handle this situation. > > + default y > > No. > Why not? This will not increase any redundant operations if there is not any boards need fix. You can see my fix.c code. Regards, -Dongsheng > -Scott > _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
