On Thu, Jun 05, 2014 at 08:21:09PM -0700, Sukadev Bhattiprolu wrote: SNIP
> index 7409ac8..3f97cf2 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1288,8 +1288,10 @@ static int machine__resolve_callchain_sample(struct > machine *machine, > { > u8 cpumode = PERF_RECORD_MISC_USER; > int chain_nr = min(max_stack, (int)chain->nr); > + enum chain_order order = callchain_param.order; > int i; > int err; > + int skip_idx; > > callchain_cursor_reset(&callchain_cursor); > > @@ -1298,14 +1300,13 @@ static int machine__resolve_callchain_sample(struct > machine *machine, > return 0; > } > > + skip_idx = arch_skip_callchain_idx(machine, thread, chain); > + > for (i = 0; i < chain_nr; i++) { > u64 ip; > struct addr_location al; > > - if (callchain_param.order == ORDER_CALLEE) > - ip = chain->ips[i]; > - else > - ip = chain->ips[chain->nr - i - 1]; > + ip = next_callchain_ip(chain, order, i, skip_idx); hum, I still dont see a point of adding new user enum API (PERF_CONTEXT_IGNORE) when we can just do: #ifdef HAVE_SKIP_CALLCHAIN_IDX if (idx == skip_idx) continue; #endif if (callchain_param.order == ORDER_CALLEE) ip = chain->ips[i]; else ip = chain->ips[chain->nr - i - 1]; jirka > > if (ip >= PERF_CONTEXT_MAX) { > switch (ip) { > @@ -1318,6 +1319,8 @@ static int machine__resolve_callchain_sample(struct > machine *machine, > case PERF_CONTEXT_USER: > cpumode = PERF_RECORD_MISC_USER; > break; > + case PERF_CONTEXT_IGNORE: > + break; > default: > pr_debug("invalid callchain context: " > "%"PRId64"\n", (s64) ip); > -- > 1.7.9.5 > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev