Hi Arnd, Thanks a lot for your review. I will update it in next version.
Best regards, Vincent Yang 2014-06-20 18:00 GMT+08:00 Arnd Bergmann <a...@arndb.de>: > On Friday 20 June 2014 17:35:26 Vincent Yang wrote: >> +Required properties: >> +- compatible: "fujitsu,f_sdh30" >> + >> +Optional properties: >> +- gpios: Specify gpios for controlling signal level >> +- clocks: Specify clocks used by SDHCI controller >> +- clock-names: Specify the clock-names to be used > > If you want to use "clock-names", you have to specify the exact names > of the clock input signals used by your device, and the order in which > they are listed. > > For both the clocks and the gpios, you have to specify how many signals > there are, and ideally describe what they are used for. In case of a > gpio controlling the signal level, it may be better to model this > as a gpio-regulator device, depending on how exactly it is used. > > When posting a DT binding document, please always add > devicet...@vger.kernel.org to Cc. > > Arnd _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
