________________________________________ From: Wood Scott-B07421 Sent: Wednesday, June 25, 2014 1:34 AM To: Zhao Qiang-B45475 Cc: linuxppc-dev@lists.ozlabs.org; linux-...@vger.kernel.org; w...@grandegger.com; m...@pengutronix.de Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan
On Mon, 2014-06-23 at 01:20 -0500, Zhao Qiang-B45475 wrote: > On Sat, 2014-06-21 at 12:19, Wood Scott wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Saturday, June 21, 2014 12:19 AM > > To: Zhao Qiang-B45475 > > Cc: linuxppc-dev@lists.ozlabs.org; linux-...@vger.kernel.org; > > w...@grandegger.com; m...@pengutronix.de; Wood Scott-B07421 > > Subject: Re: [PATCH v2 1/2] flexcan: add err_irq handler for flexcan > > > > On Fri, 2014-06-20 at 10:01 +0800, Zhao Qiang wrote: > > > when flexcan is not physically linked, command 'cantest' will trigger > > > an err_irq, add err_irq handler for it. > > > > > > Signed-off-by: Zhao Qiang <b45...@freescale.com> > > > --- > > > Changes for v2: > > > - use a space instead of tab > > > - use flexcan_poll_state instead of print > > > > > > drivers/net/can/flexcan.c | 31 ++++++++++++++++++++++++++++++- > > > 1 file changed, 30 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c > > > index f425ec2..7432ba4 100644 > > > --- a/drivers/net/can/flexcan.c > > > +++ b/drivers/net/can/flexcan.c > > > @@ -208,6 +208,7 @@ struct flexcan_priv { > > > void __iomem *base; > > > u32 reg_esr; > > > u32 reg_ctrl_default; > > > + unsigned int err_irq; > > > > Why unsigned? > Err_irq is from 0. So? irqs are plain "int" almost everywhere in the kernel. OK, I will change it. -Zhao _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev