> -----Original Message----- > From: Wood Scott-B07421 > Sent: Friday, July 04, 2014 3:40 AM > To: Jain Priyanka-B32167 > Cc: devicet...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > s...@vger.kernel.org; linux-...@lists.infradead.org > Subject: Re: [PATCH] devicetree/bindings: Add binding for micron n25q512a > memory > > On Thu, 2014-07-03 at 15:42 +0530, Priyanka Jain wrote: > > -Micron n25q512a memory is supported by m25p80 driver. > > Add compatible field required to support n25q512a in m25p80.txt -Add > > micron to the vendor-prefixes.txt file > > > > Signed-off-by: Priyanka Jain <priyanka.j...@freescale.com> > > --- > > Documentation/devicetree/bindings/mtd/m25p80.txt | 1 + > > .../devicetree/bindings/vendor-prefixes.txt | 1 + > > 2 files changed, 2 insertions(+), 0 deletions(-) > > Why did you send this to the ppc list but not the spi or mtd lists? > [Jain Priyanka-B32167] Sorry, I missed that > I'm having a hard time following the flow of how these SPI devices get > bound -- is the compatible involved at all? I don't see this string > (with vendor prefix included) in the driver. I do see a table that > contains what looks like device IDs. If the device can report its id, > shouldn't we rely on that rather than device tree compatible? > > -Scott [Jain Priyanka-B32167] Spi driver has a check to device name corresponding to device-id and compare to what is passed in dts string. New checkpatch script search for exact string match in binding folder. So, I have added this in example. > > > > diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt > > b/Documentation/devicetree/bindings/mtd/m25p80.txt > > index 4611aa8..ce02e81 100644 > > --- a/Documentation/devicetree/bindings/mtd/m25p80.txt > > +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt > > @@ -7,6 +7,7 @@ Required properties: > > the DT binding is not Linux-only, but in case of Linux, > see the > > "spi_nor_ids" table in drivers/mtd/spi-nor/spi-nor.c > for the list > > of supported chips. > > + example: "micron,n25q512a" > > - reg : Chip-Select number > > - spi-max-frequency : Maximum frequency of the SPI bus the chip can > > operate at > > > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt > > b/Documentation/devicetree/bindings/vendor-prefixes.txt > > index 4d7f375..a44cfee 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > > @@ -79,6 +79,7 @@ marvell Marvell Technology Group Ltd. > > maxim Maxim Integrated Products > > micrel Micrel Inc. > > microchip Microchip Technology Inc. > > +micron Micron Technology Inc. > > mosaixtech Mosaix Technologies, Inc. > > moxa Moxa > > mpl MPL AG >
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
