On Wed, Nov 26, 2014 at 09:54:53AM +1100, Benjamin Herrenschmidt wrote: >On Tue, 2014-11-25 at 09:38 +1100, Gavin Shan wrote: >> The patchset corresponds to skiboot changes, which manages PCI slots >> in a unified way: OPAL APIs used to do slot reset, power management, >> presence status retrival. The patchset shouldn't be merged before >> the OPAL firmware counterpart is merged. > >This doesn't work. We need to have both backward and forward >compatibility. > >IE. New kernels must work with old OPAL and vice-versa. >
Yes, it's known issue as you remind me yesterday. I'll fix it in next revision, from skiboot (I guess it would be official name to be used now) side. >> The kernel changes have been split into 2 parts: (A) Use the unified >> PCI slot reset OPAL API - this patchset; (B) Changes to rpaphp.ko to >> support PCI slot hotplug via sysfs entries for PowerPC PowerNV platform. > >I don't think we should be using rpaphp... we should be creating our new >backend, there is almost no commonalities between RPA/PAPR and OPAL. > Ok. I'll create powernv-php as you suggested in another thread. Thank you for your time on this. Thanks, Gavin >> This patchset affects EEH, PCI reset logics, which is used mainly by >> VFIO. A couple of cases have been tested out on P7/P8 boxes and looks >> good: EEH on PowerNV, EEH support for guest, PCI passthrou. >> >> Gavin Shan (5): >> powerpc/powernv: Use PCI slot reset infrastructure >> powerpc/powernv: Refactor ioda_eeh_reset() >> powerpc/powernv: Avoid do complete reset for twice >> powerpc/powernv: Issue fundamental reset if required >> powerpc/powernv: Drop opal_pci_reinit() >> >> arch/powerpc/include/asm/eeh.h | 2 +- >> arch/powerpc/include/asm/opal.h | 31 +--- >> arch/powerpc/kernel/eeh_pe.c | 3 - >> arch/powerpc/platforms/powernv/eeh-ioda.c | 230 >> ++++++++++++++----------- >> arch/powerpc/platforms/powernv/eeh-powernv.c | 24 +-- >> arch/powerpc/platforms/powernv/opal-wrappers.S | 1 - >> arch/powerpc/platforms/powernv/pci-ioda.c | 5 +- >> arch/powerpc/platforms/pseries/eeh_pseries.c | 3 +- >> 8 files changed, 139 insertions(+), 160 deletions(-) >> >> Thanks, >> Gavin > > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev