> On Mon, 2015-02-16 at 17:56 +0700, Arseny Solokha wrote: >> Drop unused fsl_mpic_primary_get_version(), mpic_set_clk_ratio(), >> mpic_set_serial_int(). > > I'm always happy to remove unused code, but the interesting question is why > are > they unused? Please tell me in the changelog.
To being able to give a definitive answer, it's necessary to understand the intentions of original developers of these pieces. I just can tell these functions have no users and trivial grepping easily proves it; I've got the impression they are here only for the sake of implementation completeness. Two machines at hands, e300 and e500 based, boot and run without regressions on my workload with this series applied. The removed code seems also been rarely touched, so it seems the series is safe at least in general. But I can't obviously express any strong point in support of the series, so it's completely OK to leave things as is. + fsl_mpic_primary_get_version() is just a safe wrapper around fsl_mpic_get_version() for SMP configurations. While the latter is called explicitly for handling PIC initialization and setting up error interrupt vector depending on PIC hardware version, the former isn't used for anything. + As for mpic_set_clk_ratio() and mpic_set_serial_int(), they both are almost nine years old[1] but still have no chance to be called even from out-of-tree modules because they both are __init and of course aren't exported. Non-demanded functionality? Of course I'll include the last two paragraphs into the V2 patch description if the explanation is convincing enough and you ACK it. If the patch is safe it's also necessary to extend it a bit, making its second part actually a complete revert of [1]. [1] https://lists.ozlabs.org/pipermail/linuxppc-dev/2006-June/023867.html Arsény > cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev