On Wed, 2015-25-03 at 05:35:41 UTC, Daniel Axtens wrote:
Write changelogs!
Also this doesn't do what the subject suggests, it just introduces the ops
version and adds the shim. It doesn't do all the conversions.
> Signed-off-by: Daniel Axtens <d...@axtens.net>
> ---
> arch/powerpc/include/asm/pci-bridge.h | 14 ++++++++++++++
> arch/powerpc/kernel/pci-common.c | 3 +--
> 2 files changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/pci-bridge.h
> b/arch/powerpc/include/asm/pci-bridge.h
> index 3ab8a2d..2474f29 100644
> --- a/arch/powerpc/include/asm/pci-bridge.h
> +++ b/arch/powerpc/include/asm/pci-bridge.h
> @@ -18,6 +18,7 @@ struct device_node;
> * PCI controller operations
> */
> struct pci_controller_ops {
> + void (*dma_dev_setup)(struct pci_dev *dev);
> };
>
> /*
> @@ -265,5 +266,18 @@ static inline int pcibios_vaddr_is_ioport(void __iomem
> *address)
> }
> #endif /* CONFIG_PCI */
>
> +/*
> + * Shims to prefer pci_controller version over ppc_md where available.
> + */
> +static inline void dma_dev_setup(struct pci_dev *dev)
This should be called pci_dma_dev_setup() while it exists IMHO.
> +{
> + struct pci_controller *hose = pci_bus_to_host(dev->bus);
I know historically we've called them "hose", but there's also a lot of code
that uses "phb" and that is a MUCH better name, so please use that.
cheers
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
