On Mon, 2015-06-29 at 16:05 +0530, Maninder Singh wrote: > static Anlaysis detected below error:- > (error) Possible null pointer dereference: phb > > So, Use phb after NULL check. > > Signed-off-by: Maninder Singh <maninder...@samsung.com>
Thanks, looks good. Acked-By: Michael Neuling <mi...@neuling.org> > --- > drivers/misc/cxl/vphb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c > index b1d1983a..2eba002 100644 > --- a/drivers/misc/cxl/vphb.c > +++ b/drivers/misc/cxl/vphb.c > @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus, > unsigned int devfn, > unsigned long addr; > > phb = pci_bus_to_host(bus); > - afu = (struct cxl_afu *)phb->private_data; > if (phb == NULL) > return PCIBIOS_DEVICE_NOT_FOUND; > + afu = (struct cxl_afu *)phb->private_data; > + > if (cxl_pcie_cfg_record(bus->number, devfn) > afu->crs_num) > return PCIBIOS_DEVICE_NOT_FOUND; > if (offset >= (unsigned long)phb->cfg_data) _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
