From: Thomas Falcon <tlfal...@linux.vnet.ibm.com> Date: Fri, 4 Dec 2015 11:49:46 -0600
> +static int ibmvnic_buffs_per_pool = IBMVNIC_BUFFS_PER_POOL; > +module_param(ibmvnic_buffs_per_pool, int, S_IRUGO); > +MODULE_PARM_DESC(ibmvnic_buffs_per_pool, > + "IBMVNIC number of buffers per rx pool"); Please do not use module parameters for settings that effect the basic operation of the driver. Instead use facilities that are generic and provide the same user interface for all networking drivers, such as ethtool. Otherwise users would need to learn a different way to configure the same thing on different devices, which is not acceptable. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
