On 01/11/2016 08:54 AM, Hongtao Jia wrote: > Sorry for the late response. I got a knee surgery to do. > See comments at the end. > >> -----邮件原件----- >> 发件人: Arnd Bergmann [mailto:[email protected]] >> 发送时间: Saturday, December 19, 2015 6:33 AM >> 收件人: Rafael J. Wysocki <[email protected]> >> 抄送: Jia Hongtao <[email protected]>; [email protected]; >> [email protected]; [email protected]; linuxppc- >> [email protected]; [email protected]; Scott Wood >> <[email protected]> >> 主题: Re: [PATCH V3] cpufreq: qoriq: Register cooling device based on device >> tree >> >> On Tuesday 15 December 2015 00:58:26 Rafael J. Wysocki wrote: >>> On Thursday, November 26, 2015 05:21:11 PM Jia Hongtao wrote: >>>> Register the qoriq cpufreq driver as a cooling device, based on the >>>> thermal device tree framework. When temperature crosses the passive >>>> trip point cpufreq is used to throttle CPUs. >>>> >>>> Signed-off-by: Jia Hongtao <[email protected]> >>>> Reviewed-by: Viresh Kumar <[email protected]> >>> >>> Applied, thanks! >>> >> >> I got a randconfig build error today: >> >> drivers/built-in.o: In function `qoriq_cpufreq_ready': >> debugfs.c:(.text+0x1f4688): undefined reference to >> `of_cpufreq_cooling_register' >> >> CONFIG_OF=y >> CONFIG_QORIQ_CPUFREQ=y >> CONFIG_THERMAL=m >> CONFIG_THERMAL_OF=y >> >> I think you need a 'depends on THERMAL' to prevent the driver from being >> built-in when THERMAL=m. >> >> Arnd > > Correct. I need to add following lines to the Kconfig file: > depends on !CPU_THERMAL || THERMAL=y > > Hi Rafael, > Should I send a new patch include this fix or send a fix patch?
Why THERMAL=y and not just THERMAL, which would allow building this driver as a module? -Scott _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
