On 01/13/2016 04:04 AM, Benjamin Herrenschmidt wrote:
On Sun, 2016-01-10 at 01:08 -0200, Guilherme G. Piccoli wrote:weust changes the
way the arch checking is done in function
This patch jeeh_add_device_early(): we use no more eeh_enabled(), but instead
we check the running architecture by using the macro machine_is(). If we are
running on
pSeries or PowerNV, the EEH mechanism can be enabled; otherwise, we bail out
the function. This way, we don't enable EEH on Cell and we don't hit the oops
on DLPAR either.
Can't we just check for eeh_ops being NULL ?
Cheers,
Ben.
Sure, we can. I prefer the arch checking just because I think it's more
"logical", so it's easier to understand why it's there. The "cost" is
the same in practice, since the arch checking is just a macro that
checks a struct member.
What do you think it's better? Thanks for the review.
Cheers,
Guilherme
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
