On 10/26/06, Grant Likely <[EMAIL PROTECTED]> wrote:
> On 10/26/06, Nicolas DET <[EMAIL PROTECTED]> wrote:
> > -       chrp_find_openpic();
> > -       chrp_find_8259();
> > +
> > +       if ( chrp_find_mpc52xx_pic() < 0)
> > +       {
> > +               chrp_find_openpic();
> > +               chrp_find_8259();
> > +       }
>
> Why?  Why not just add the call to chrp_find_mpc52xx_pic() before or
> after the other two chrp_find_ calls?  Will calling them cause things
> to break?
>
> Keep the code simple.

... as possible; but no simpler.

:)

g.

-- 
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
[EMAIL PROTECTED]
(403) 399-0195
_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded

Reply via email to