On Mon, 6 Nov 2006, Vitaly Bordug wrote: >> This patch renames these the two existing resources, and introduces a >> new one, "pram_base", which is a pointer to the parameter RAM. The >> parameter RAM for SMC1 and SMC2 is put in the first 128 bytes of the >> DPRAM. This memory was already reserved from the DPRAM memory >> allocator for this purpose. >> > Well just one objection. pram_base should not be a device unless it applies > to all the stuff of > SoC family which is not the case. > > For this aim, I'd put what you need into the platform_data, or follow the > same approach 8xx stuff having.
I'm not sure I follow you now. "pram_base" is not a device by itself, but it's just another resource in the PQ2 version of the SMC devices in the platform_data. So the resource is only present when it is needed, and for other platform devices that don't have this resource, the cpm_uart code does nothing (as it should not). The only difference to the 8xx version is the new "pram_base" resource, and it is required with PQ2, right? _______________________________________________ Linuxppc-embedded mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-embedded
