Marcelo Tosatti wrote: > On Wed, Aug 10, 2005 at 02:16:57PM -0500, Kumar Gala wrote: > >>+static int __init find_chip_by_name_and_id(char *name, u32 id) >>+{ >>+ int ret = -1; >>+ unsigned int i = 0; >>+ unsigned int j = 0; >>+ unsigned int dups = 0; >>+ >>+ unsigned int matched[count_sys_specs()]; >> >>Is is legit in the kernel to use dynamically sized array? > > > kmalloc() is certainly safer - why not use it? Practically , version with kmalloc works, but setup_arch and thus this function is called before mem_init, so I just wonder if kmalloc can handle this case. On the other hand, I don't like to deal with alloc_bootmem() if mem_init_done!=1 and kmalloc otherwise (like ocp does) just for the temporary buffer.
But it's the only _right_ way (or I 've missed something) - sure I'll follow it. -- Sincerely, Vitaly