Dan Malek wrote: > > On Aug 19, 2005, at 8:44 AM, Vitaly Bordug wrote: > >> +#define MPC8xx_INT_FEC1 SIU_LEVEL1 >> +#define MPC8xx_INT_FEC2 SIU_LEVEL3 >> + >> +#define MPC8xx_INT_SCC1 (CPM_IRQ_OFFSET + CPMVEC_SCC1) >> +#define MPC8xx_INT_SCC2 (CPM_IRQ_OFFSET + CPMVEC_SCC2) >> +#define MPC8xx_INT_SCC3 (CPM_IRQ_OFFSET + CPMVEC_SCC3) >> +#define MPC8xx_INT_SCC4 (CPM_IRQ_OFFSET + CPMVEC_SCC4) >> +#define MPC8xx_INT_SMC1 (CPM_IRQ_OFFSET + CPMVEC_SMC1) >> +#define MPC8xx_INT_SMC2 (CPM_IRQ_OFFSET + CPMVEC_SMC2) >> + >> +/* Offset from IMMAP base address */ >> +#define MPC8xx_SCC1_OFFSET (0xa00) >> +#define MPC8xx_SCC1_SIZE (0x18) >> +#define MPC8xx_SCC2_OFFSET (0xa20) >> +#define MPC8xx_SCC2_SIZE (0x18) >> +#define MPC8xx_SCC3_OFFSET (0xa40) >> +#define MPC8xx_SCC3_SIZE (0x18) >> +#define MPC8xx_SCC4_OFFSET (0xa60) >> +#define MPC8xx_SCC4_SIZE (0x18) >> +#define MPC8xx_SMC1_OFFSET (0xa82) >> +#define MPC8xx_SMC1_SIZE (0x0f) >> +#define MPC8xx_SMC2_OFFSET (0xa92) >> +#define MPC8xx_SMC2_SIZE (0x0d) >> +#define MPC8xx_FEC1_OFFSET (0xe00) >> +#define MPC8xx_FEC1_SIZE (0x88) >> +#define MPC8xx_FEC2_OFFSET (0x1e00) >> +#define MPC8xx_FEC2_SIZE (0x88) >> + >> +#define MPC8xx_DPARAM_SCC1_OFFSET (0x3C00) >> +#define MPC8xx_DPARAM_SCC1_SIZE (0x80) >> +#define MPC8xx_DPARAM_SCC2_OFFSET (0x3D00) >> +#define MPC8xx_DPARAM_SCC2_SIZE (0x80) >> +#define MPC8xx_DPARAM_SCC3_OFFSET (0x3E00) >> +#define MPC8xx_DPARAM_SCC3_SIZE (0x80) >> +#define MPC8xx_DPARAM_SCC4_OFFSET (0x3F00) >> +#define MPC8xx_DPARAM_SCC4_SIZE (0x80) >> +#define MPC8xx_DPARAM_SMC1_OFFSET (0x3E80) >> +#define MPC8xx_DPARAM_SMC1_SIZE (0x40) >> +#define MPC8xx_DPARAM_SMC2_OFFSET (0x3F80) >> +#define MPC8xx_DPARAM_SMC2_SIZE (0x40) > > > All of these #defines should already be in a header file somewhere, > and if they aren't, should be in the generic CPM header file. > Please clean this up. > > Thanks. > > -- Dan > > I am going to move interrupts to the generic CPM header file, others I guess may be cleanup'ed, with replace respective defines in the source by pure numbers (as was done previously for PQ2 platform stuff).
-- Sincerely, Vitaly