>> @@ -36,6 +36,10 @@ static int __devinit of_platform_serial_setup(struct
>> of_device *ofdev,
>> memset(port, 0, sizeof *port);
>> spd = of_get_property(np, "current-speed", NULL);
>> clk = of_get_property(np, "clock-frequency", NULL);
>> + if (!spd) {
>> + dev_warn(&ofdev->dev, "no current-speed property set\n");
>> + return -ENODEV;
>> + }
>> if (!clk) {
>> dev_warn(&ofdev->dev, "no clock-frequency property set\n");
>> return -ENODEV;
>
> This looks wrong. Since the current-speed property is not mandated by open
> firmware,
> we should not error out here, but simply use the setting from the command
> line
> or whatever other defaults can be used. Not setting port->custom_divisor at
> all
> should do the job.
Understood... but then, my console just stops / gets reinitialized to some
unknown
baudrate when I get to of_serial.c. :-(
Regards,
Clemens Koller
__________________________________
R&D Imaging Devices
Anagramm GmbH
Rupert-Mayer-Straße 45/1
Linhof Werksgelände
D-81379 München
Tel.089-741518-50
Fax 089-741518-19
http://www.anagramm-technology.com
_______________________________________________
Linuxppc-embedded mailing list
Linuxppc-embedded@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-embedded
