> -----Original Message----- > From: Sebastian Siewior [mailto:[EMAIL PROTECTED] > Sent: Tuesday, July 01, 2008 2:19 AM > To: Li Yang > Cc: Zhang Wei; linuxppc-embedded@ozlabs.org; > [EMAIL PROTECTED] > Subject: [PATCH] DMA Engine: fix error path(s) in fsl-dma driver > > of_fsl_dma_probe: > - kfree(NULL) doesn't hurt but dereferencing the pointer in > iounmap does > - also, the irq can be freed > > of_fsl_dma_chan_probe: > - iounmap(NULL) resolved in vunmap() what which in turn is > able to handle NULL > pointer but dereferencing still doesn't work > - don't clean up not yet allocated ressources, like list_del > before list_add > > fsl_dma_self_test: > - call fsl_dma_free_chan_resources() if the first dma trans > didn't complete
Thanks Sebastian, But similar patch has already been waiting in sub-system maintainer's tree which can be found at http://git.kernel.org/?p=linux/kernel/git/djbw/async_tx.git;a=commit;h=29ec9bdef73d68134e7070ee91ccda0718d46150 - Leo _______________________________________________ Linuxppc-embedded mailing list Linuxppc-embedded@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-embedded