On Nov 30, 2013, at 9:24 AM, Richard Cochran <[email protected]> wrote:
> On Tue, Nov 19, 2013 at 02:42:38PM +0100, Delio Brignoli wrote: >> Signed-off-by: Delio Brignoli <[email protected]> >> --- >> port.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/port.c b/port.c >> index 94c5cac..5604987 100644 >> --- a/port.c >> +++ b/port.c >> @@ -1937,6 +1937,7 @@ static void port_p2p_transition(struct port *p, enum >> port_state next) >> port_disable(p); >> break; >> case PS_LISTENING: >> + set_tmo_log(p->fda.fd[FD_MANNO_TIMER], 1, -10); /*~1ms*/ > > Delio, I don't think this is right. The MANNO timer is for controlling > when to send announce messages. According to 1588, announce messages > may only be sent by ports in the MASTER state. I see, I didn't have time to look up 1588 when I was fixing this issue. > Or what where you trying to fix here? >From memory, the problem was that when running in slave-only mode linuxptp >didn't start announcing when the port became asCapable. According to 802.1AS >we should be announcing ourselves immediately when the port becomes asCapable >even if we do not support being master. Thanks -- Delio > > Thanks, > Richard > > >> port_set_announce_tmo(p); >> break; >> case PS_PRE_MASTER: >> @@ -1993,6 +1994,7 @@ int port_dispatch(struct port *p, enum fsm_event >> event, int mdiff) >> port_show_transition(p, next, event); >> p->state = next; >> if (next == PS_LISTENING && p->delayMechanism == DM_P2P) { >> + set_tmo_log(p->fda.fd[FD_MANNO_TIMER], 1, -10); /*~1ms*/ >> port_set_delay_tmo(p); >> } >> return 1; >> -- >> 1.7.0.4 >> >> >> >> >> ------------------------------------------------------------------------------ >> Shape the Mobile Experience: Free Subscription >> Software experts and developers: Be at the forefront of tech innovation. >> Intel(R) Software Adrenaline delivers strategic insight and game-changing >> conversations that shape the rapidly evolving mobile landscape. Sign up now. >> http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk >> _______________________________________________ >> Linuxptp-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk _______________________________________________ Linuxptp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
