On Mon, 2013-12-02 at 23:24 +0100, Richard Cochran wrote:
> On Mon, Oct 28, 2013 at 11:56:27AM -0700, Jacob Keller wrote:
>
> > @@ -229,11 +229,12 @@ int sk_receive(int fd, void *buf, int buflen,
> > struct pollfd pfd = { fd, 0, 0 };
> > res = poll(&pfd, 1, sk_tx_timeout);
> > if (res < 1) {
> > - pr_err(res ? "poll tx timestamp failed: %m" :
> > - "poll tx timestamp timeout");
> > + pr_err(res ? "poll for tx timestamp failed: %m" :
> > + "timed out while polling for tx
> > timestamp");
> > + pr_err("increasing the tx_timestamp_timeout may correct
> > this issue, but it is likely caused by a driver bug");
>
> I just noticed that this second error message appears after a link
> failure (like pulling out the Ethernet cable), and in that case the
> message gives the total wrong impression.
>
> I would suggest that we change this pr_err into a pr_debug and then
> list all three possibilities as hints:
>
> 1. driver need more time
> 2. driver bug
> 3. interface or link down
>
> Thanks,
> Richard
Agreed. I am pretty busy with some things, so I won't be able to get a
patch together for this today. If you (or someone else) hasn't gotten to
it sometime in the next day I will try to put a patch together.
Regards,
Jake
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
