First of all, the linuxptp project is one of my favorite open source projects because one can see that people really care about the code. For instance, the code compiles very cleanly.
To keep the very good level I would like to introduce some more stricter warnings in the makefile. That's my suggestion: -Wstrict-overflow=5 (no warning on the existing code basis, that's great!) -Wpointer-arith (no warnings on the existing code basis) -Wformat=2 (no warnings on the existing code basis) -Wcast-align (no warnings on the existing code basis) -Wmissing-declarations (very few and easy to fix warnings) -Wextra (gives some warnings about sing/unsigned comparisons) and probably -Wwrite-strings The latter is debatable. In gives string constants the type const char[], so it can give us warnings if someone tries to write into such constants. But this stuff requires to make all functions const correct, which is some annoying work to do. I would volunteer for this, but only if we agree that we would like to have it. So what's your opinion on that? Regards, Stephan ------------------------------------------------------------------------------ Managing the Performance of Cloud-Based Applications Take advantage of what the Cloud has to offer - Avoid Common Pitfalls. Read the Whitepaper. http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk _______________________________________________ Linuxptp-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
