On Mon, 2015-08-03 at 22:02 +0200, Richard Cochran wrote:
> I have no problem with adding these options.
>
> On Mon, Aug 03, 2015 at 03:49:43PM +0200, Miroslav Lichvar wrote:
> > +unsigned char udp_ttl = 1;
> ...
>
> > + if (setsockopt(fd, IPPROTO_IP, IP_MULTICAST_TTL, &udp_ttl,
> > + sizeof(udp_ttl))) {
> > + pr_err("setsockopt IP_MULTICAST_TTL failed: %m");
> > + goto no_option;
> > + }
>
> This would be better it it were a per-port option, no?
>
> I want to start reworking the config API to make it easier and
> cleaner
> to add and make use of options. (Jake and I discussed this a bit
> off-list.) I'll hold on this patch until we have something. In
> fact,
> I might just use this change as a guinea pig, if you don't mind!
>
> Thanks,
> Richard
Yea. We discussed some ideas, but I have not had any more time to work
on the ideas myself. One option I've recently considered is maybe
porting some library inline to our code that might make it easier than
re-writing all the bits ourselves.. May not be worth it at all but
worth considering ie: static inline a (GPL) library that does what we
need, rather than write our own.. but do so in a way that doesn't
require users to actually install the library themselves.. It's an
option we might want to consider.
Regards,
Jake
------------------------------------------------------------------------------
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
