I think you are right. That 'tos_*' naming thing has grown historically and I didn't spend much into the naming afterwards. I'll provide a patch soon to rename that options as according to your suggestion (have to get the current git verison before).
Best regards Henry Jesuiter -----Ursprüngliche Nachricht----- Von: Miroslav Lichvar [mailto:mlich...@redhat.com] Gesendet: Dienstag, 12. Juli 2016 08:54 An: Jesuiter, Henry (ALC NetworX GmbH) <henry.jesui...@alcnetworx.de> Cc: Richard Cochran <richardcoch...@gmail.com>; linuxptp-devel@lists.sourceforge.net Betreff: Re: [Linuxptp-devel] [PATCH] Introduce options to set DSCP values in PTP messages On Fri, Jul 08, 2016 at 07:46:25AM +0000, Jesuiter, Henry (ALC NetworX GmbH) wrote: > In the last years there are several media streaming standards > evolving that are relying on PTP. These standards make requirements > about the DSCP priority of PTP messages. This patch introduces two > new configuration options 'tos_event' and 'tos_general' to address > that issue and to be able to set the DSCP priority separately for > PTP event messages and PTP general messages. If the new options set the DSCP value, should they be named tos_*? I suspect it might create a confusion with the IPv4 TOS field, which contains bitshifted DSCP. Wouldn't dscp_event and dscp_general be better? -- Miroslav Lichvar ------------------------------------------------------------------------------ What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. Reveals which users, apps, and protocols are consuming the most bandwidth. Provides multi-vendor support for NetFlow, J-Flow, sFlow and other flows. Make informed decisions using capacity planning reports.http://sdm.link/zohodev2dev _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
