On Thu, Apr 06, 2017 at 12:08:29PM +0200, Burkhard Ilsen wrote: > Hearing no complains I propose the attached patch. > > > Like Jake said, your patch is whitespace damaged. > Thanks for the info, I am now using your pre-commit hook.
There is still an odd hunk adding some whitespace. As for the change itself, it makes sense to me, but I think the "tmv_is_zero(tsp->filtered_delay))" check could prevent updates if the measured and filtered delay is actually zero (which can happen for various reasons). I'd suggest to define a special value for an unknown delay (e.g. the minimum or maximum tmv_t value?), or add a new field to be used as a flag. -- Miroslav Lichvar ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
