> -----Original Message----- > From: Chris Perl [mailto:cp...@janestreet.com] > Sent: Tuesday, January 09, 2018 3:07 PM > To: Miroslav Lichvar <mlich...@redhat.com> > Cc: linuxptp-devel@lists.sourceforge.net > Subject: Re: [Linuxptp-devel] [PATCH] sk: Restrict warnings about drivers > changing RX filter. > > On Tue, Jan 9, 2018 at 11:00 AM, Miroslav Lichvar <mlich...@redhat.com> wrote: > > > > An advantage of this patch is that we will get warnings about drivers > > incorrectly reporting supported filters, like with the X550 for > > instance. > > Perhaps slightly off topic, but what filters does the X550 say it > supports but doesn't? >
X550 always upscales to PTP_HWTSTAMP_ALL, which means it "supports" every filter. However, according to the documentation of the ethtool timestamp info ioctl, you should only report the values for which you directly support, without upscaling. I believe until Miroslav's most recent patch, the X550 driver was reporting that it supported all the various filters, despite the documentation indicating that it should only report the most generic filters it supports. Thanks, Jake ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
