On Fri, Mar 23, 2018 at 01:24:35PM +0100, Peter Schneider wrote:
> @@ -1477,6 +1482,10 @@ int main(int argc, char *argv[])
>               }
>       }
>  
> +     if (config && (c = config_read(config, cfg))) {
> +             return c;
> +     }
> +

This is not quite right.  I noticed that some of the run time
variables do *not* go through the config API, but they should:

   | phc2sys variable       | config. option    |
   |------------------------+-------------------|
   | domain_number          | domainNumber      |
   | node.kernel_leap       | kernel_leap       |
   | node.sanity_freq_limit | sanity_freq_limit |
   | node.servo_type        | clock_servo       |
   | print_level            | logging_level     |
   | use_syslog             | use_syslog        |
   | verbose                | verbose           |

After adding the '-f' option, the user expects that changing the
option in the file will change the variable in the program, but as of
now this will have no effect.

So before adding the config file option, we first must clean up how
these variables are assigned.

Thanks,
Richard


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to