> -----Original Message----- > From: Anders Selhammer [mailto:anders.selham...@est.tech] > Sent: Friday, April 20, 2018 3:14 AM > To: linuxptp-devel@lists.sourceforge.net > Subject: [Linuxptp-devel] [PATCH 6/7] bmc: Added dscmp_alternate > > /** > * BMC state decision algorithm. > * @param c The local clock. > @@ -54,6 +59,16 @@ enum port_state bmc_state_decision(struct clock *c, struct > port *r, > int dscmp_ieee1588(struct dataset *a, struct dataset *b); > > /** > + * Compare two data sets using the algorithm defined in ITU-T G.8275.1. > + * @param a A dataset to compare. > + * @param b A dataset to compare. > + * @return An integer less than, equal to, or greater than zero > + * if the dataset @a a is found, respectively, to be > + * less than, to match, or be greater than @a b. > + */ > +int dscmp_alternate(struct dataset *a, struct dataset *b); > +
Would it make more sense if the function included something indicating the standard here? Alternate seems a bit vague. > +/** > * Second part of the data set comparison algorithm, not for general > * public use. > */ > -- > 1.8.3.1 > ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
