Friday, July 6, 2018 10:08 PM

> This series is a rework of Anders' SNMP v3 series.

> Here is what changed:
> - dropped first two patches as they have been merged
> - renamed snmpd to snmp4lptp to avoid clash with net-snmp
> - simplified build
> - support cross compilation

> Please review and test!

Hi, sorry for late reply. I'm on vacation and I planned to work on the 
rainy days, but as the situation is right now in Sweden, we have no rain...

But I logged in anyway and noticed that you were pretty fast on the update.
Thanks for updating all the patches, saved me some time tonight 😊

I have looked through all the three patches and also tested it with some mib 
implementation and its works as before (not tested CC).

I only have two things, which was not included in my patch 
Added it later on while doing some mib work.

1.
In the first patch, add:
/snmp4lptp
in .gitignore

2.
In the third patch, update:
-       if (pmc_do_command(pmc, cmd)) {
+       if (cmd && pmc_do_command(pmc, cmd)) {

This to add the possibility to call function without a cmd to just get a 
message.
Used for get port ds for example. pmc_common send a message for all ports 
and the program should receive them all.  


I can also do these updates in next series with some mib implementation, 
does not really matter.

I'm still on vacation but I will try to read the mail more frequently 😊

/Anders  
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to