> -----Original Message-----
> From: Richard Cochran [mailto:[email protected]]
> Sent: Monday, November 5, 2018 9:27 PM
> To: Patel, Vedang <[email protected]>
> Cc: [email protected]; Sanchez-Palencia, Jesus
> <[email protected]>; Gomes, Vinicius
> <[email protected]>; Guedes, Andre <[email protected]>;
> Hindman, Gavin <[email protected]>
> Subject: Re: [PATCH v1 7/7] port: Add inhibit_delay_req.
> 
> On Fri, Oct 05, 2018 at 04:25:07PM -0700, Vedang Patel wrote:
> > Add provision to disable delay requests. Designated masters who do not
> > need to calculate delay can use this option. This is required by
> > Automotive Profile to reduce network load.
> >
> > Signed-off-by: Vedang Patel <[email protected]>
> > ---
> >  config.c                      | 1 +
> >  configs/automotive-master.cfg | 1 +
> >  port.c                        | 5 +++++
> >  port_private.h                | 1 +
> >  ptp4l.8                       | 5 +++++
> >  5 files changed, 13 insertions(+)
> >
> > diff --git a/config.c b/config.c
> > index 9c8f703d4bbd..bd1f53f93bc3 100644
> > --- a/config.c
> > +++ b/config.c
> > @@ -246,6 +246,7 @@ struct config_item config_tab[] = {
> >     PORT_ITEM_INT("ingressLatency", 0, INT_MIN, INT_MAX),
> >     PORT_ITEM_INT("inhibit_announce", 0, 0, 1),
> >     PORT_ITEM_INT("inhibit_multicast_service", 0, 0, 1),
> > +   PORT_ITEM_INT("inhibit_delay_req", 0, 0, 1),
> 
> Shouldn't this be "inhibit_pdelay_req"?
> 
> gPTP aka 802.1-AS is peer delay only, and so is the automotive profile.
> 
> Inhibiting e2e delay requests doesn't make sense, because master ports never
> send them.
> 

Yeah it makes sense. I will move this to only inhibit pdelay messages.

Thanks,
Vedang

> Thanks,
> Richard


_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to