On Mon, Nov 12, 2018 at 06:42:37AM -0800, Richard Cochran wrote: > On Mon, Nov 12, 2018 at 07:14:31AM +0000, Anders Selhammer wrote: > > I use more than one network namespace for the stack yes. Ports in different > > namespace. > > This series really needs a cover letter that describes the use case(s) > in some detail. As it stands, we are all wondering, "why would anyone > want this?"
Also, the cover letter should introduce each patch, something like: Patches 1-3 are random fixes found along the way. Patches 4-6 introduce the new functionality. Also, each patch needs a commit message. A proper message needs: 1. context 2. problem 3. solution That makes three sentences. This can and should be done even for trivial patches. For example, your patch 4/6 could say: In order to avoid stack overflows, the snprintf() needs the size of the buffer. The GUID logic inadvertently passes the length of a different buffer to that function. Although the buffers happen to have the same length, still this patch fixes the oversight by using the size of the correct buffer. Thanks, Richard _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel