On Mon, Dec 23, 2019 at 11:03:54AM -0800, Richard Cochran wrote: > And so the phc2sys.c starting at line 767 should read: > > /* use reversed sysoff */ > if (sysoff_measure(CLOCKID_TO_FD(clock->clkid), > clock->sysoff_method, > node->phc_readings, > &offset, &ts, &delay) < 0) > return -1; > offset = -offset; > ts += offset; > > Miroslav, care to double check that?
That looks correct to me. I did a different test to verify it works as expected now. Thanks for the report and fix. My logic is often faulty when dealing with offset signs, so I've learned to not trust it and test the code both ways to make sure it's correct, which I remember quite clearly doing with this patch. I'm not sure what went wrong. -- Miroslav Lichvar _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
