Am 2020-03-20 18:32, schrieb Richard Cochran:
On Tue, Mar 17, 2020 at 04:41:14PM +0000, Rodney Cummings wrote:
Recommendation: Keep to 802.1AS-2011 bridge for the upcoming patches.
Okay.
Recommendation: After 802.1AS-2011 bridge is in the Linuxptp master,
NI runs the UNH-IOL Conformance bridge tests, and submits category A)
and B) failures to Linuxptp.
I really appreciate NI's offer of help in testing. Could you run the
Conformance test on the patches before I merge them to master?
I don't think hacking the 802.1AS stuff into BC is a good fit:
- the SYNCs are forwarded upon reception of a SYNC packet; then
the correction field is updated.
- there is no concept of syncLocked in the current standards. Only
the new 802.1AS-REV (and I guess that will be the 802.1AS-2020?!
introduces that. But even in that case, the correction field is
updated based on the last received sync. So it is more a TC with
some artificial update.
- as far as I understand the standard, the source port ID is the one
from the grandmaster. Strange enough most implementations get this
wrong. Maybe I'm wrong, it is very hard to follow that standard.
There is also this patch
[RFC V3, 3/4] port: drop erroneous neighbor rate ratio
which I don't know why it is there. In my experience, this patch make
things just worse. It won't sync anymore if the rate ratio is too high.
While this might be mandatory to be compliant, I really question whether
it is actually useful. So generic question, do we want to follow the
standard no matter what, or do we want to be on the safe side and try
to actually sync the clocks?
-michael
If it helps your workflow, I can surely put those patches on a branch
on Github for you.
Thanks,
Richard
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
