On 10/23/20 2:13 AM, Richard Cochran wrote: > On Thu, Oct 22, 2020 at 11:17:51AM +0000, Matt Sanders (matt8) via Linuxptp-devel wrote: > >> It is possible for 802.3 Ethernet adapters to be configured include the Ethernet >> CRC value in the raw frame which will be returned by the PF_PACKET / SOCK_RAW >> interface used by Linux PTP. This is configured on a per interface basis >> (e.g. ethtool -K eth1 rx-fcs on) and is independent of using Linux PTP on that >> interface (e.g. some other application may want or need this to be configured). > > If this configuration truly needs to be supported, then the code in > raw.c should handle the extraneous length before returning from > raw_recv(). >
Yes, I had considered that. The trouble is, to support this in raw_recv() would require some fairly nasty querying of the configured interface properties using the ethtool interfaces. I’m sure this could be done, but it would more complex and thus more brittle than the proposed fix. The proposed fix is simple, clean and uses the mechanisms that the standard implies to resolve the problem. What’s your objection to going down this path? Regards, Matt S. _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
