On Sun, Feb 21, 2021 at 02:08:02PM EST, Richard Cochran wrote:
>On Mon, Feb 15, 2021 at 09:58:53AM -0500, vincent.cheng...@renesas.com wrote:
>> @@ -1730,7 +1743,10 @@ enum servo_state clock_synchronize(struct clock *c, 
>> tmv_t ingress, tmv_t origin)
>>  
>>      c->cur.offsetFromMaster = tmv_to_TimeInterval(c->master_offset);
>>  
>> -    if (c->free_running) {
>> +    if (c->free_running || c->step_window_counter) {
>> +            if (c->step_window_counter) {
>> +                    c->step_window_counter--;
>> +            }
>>              return clock_no_adjust(c, ingress, origin);
>
>This isn't quite right.  clock_no_adjust() will return the wrong servo
>state.  Also, we want to prevent the Sync messages from entering the
>tsproc.
>
>I think the correct way is to drop the Sync messages altogether.
>
>I hacked your patch with my suggested changes, and I'll post it
>shortly.  Please review it and let me know what you think.

I have reviewed the hacked patch and it looks good.  Works for me.
Thank-you.

Vincent


_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to