On 10/03/2021 00:38, Keller, Jacob E wrote: >> -----Original Message----- >> From: Geva, Erez<erez.geva....@siemens.com> >> Sent: Tuesday, March 09, 2021 2:29 PM >> To: Richard Cochran<richardcoch...@gmail.com> >> Cc:linuxptp-devel@lists.sourceforge.net >> Subject: Re: [Linuxptp-devel] PORT_STATS_NP management TLV message >> >> Hi, >> >> I can be live with using little endian. >> This is not the first time I see using little endian with IEEE. >> >> However with the current code the endian depends on machine. >> So a linuxptp daemon that runs on a big endian (there are yet some) will >> send the >> message in big endian. >> >> May be we should limit this TLV message to UDS only? >> Since UDS always run on the same machine. >> >> Erez >> > If it only runs on the same machine there should be no issue. Even if it > crosses network I think just documenting that the format is in "host" endian > and adding a configuration option to pmc tool that allows you to set the > format to read the command output in would be enough? > > Alternatively we can add a new PORTS_STATS_STRICT_NP or something which would > strictly use either Big or Little endian format, and then work on deprecating > the old format... > > Thanks, > Jake --
I see the same issue in: TLV_TIME_STATUS_NP TLV_GRANDMASTER_SETTINGS_NP TLV_SUBSCRIBE_EVENTS_NP TLV_PORT_DATA_SET_NP Do you think we should add "STRICT" version, add "endian" flag to pmc or both? Or limit all the managment XX_NP to UDS? Erez _______________________________________________ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
