Hi Richard,
Hi All,
I noticed the following code inside port_link_status():
/*
* A port going down can affect the BMCA result.
* Force a state decision event.
*/
if (p->link_status & LINK_DOWN)
clock_set_sde(p->clock, 1);
I think that should be removed because the calling code look like this:
case FD_RTNL:
pr_debug("port %hu: received link status notification", portnum(p));
transport_rtnl_link_status(p->trp, fd, p->name, port_link_status, p);
if (p->link_status == (LINK_UP | LINK_STATE_CHANGED))
return EV_FAULT_CLEARED;
else if ((p->link_status == (LINK_DOWN | LINK_STATE_CHANGED)) ||
(p->link_status & TS_LABEL_CHANGED))
return EV_FAULT_DETECTED;
else
return EV_NONE;
raising a EV_FAULT_DETECT on LINK_DOWN
Is my observation correct?
Thanks in advance.
luigi
--
Luigi 'Comio' Mantellini
My Professional Profile
"UNIX is very simple, it just needs a genius to understand its
simplicity." [cit.]
_______________________________________________
Linuxptp-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
