Hi Miroslav,

On Wed, 1 Jun 2022 at 13:52, Miroslav Lichvar <mlich...@redhat.com> wrote:

> On Wed, Jun 01, 2022 at 10:38:29AM +0530, SyncMonk Technologies wrote:
> > As per IEEE1588-2019, Table 21 adding NO_MECHANISM support. In this
> > case port does not implement the delay mechanism.
>
> >  static struct config_enum delay_mech_enu[] = {
> > -     { "Auto", DM_AUTO },
> > -     { "E2E",  DM_E2E },
> > -     { "P2P",  DM_P2P },
> > +     { "Auto",         DM_AUTO },
> > +     { "E2E",          DM_E2E },
> > +     { "P2P",          DM_P2P },
> > +     { "NO_MECHANISM", DM_NO_MECHANISM },
>
> Please describe the new option in the man page.
>
This has been updated with the latest patch.

>
> >  static struct config_enum tsproc_enu[] = {
> > -     { "filter",        TSPROC_FILTER        },
> > -     { "raw",           TSPROC_RAW           },
> > -     { "filter_weight", TSPROC_FILTER_WEIGHT },
> > -     { "raw_weight",    TSPROC_RAW_WEIGHT    },
> > +     { "filter",        TSPROC_FILTER                },
> > +     { "raw",           TSPROC_RAW           },
> > +     { "filter_weight", TSPROC_FILTER_WEIGHT },
> > +     { "raw_weight",    TSPROC_RAW_WEIGHT    },
> > +     { "no_delay",      TSPROC_NO_DELAY_MECHANISM    },
> >       { NULL, 0 },
>
> It's not clear to me why you are adding a new tsproc mode. If you set
> the delay with "tsproc_set_delay(0)", I think you will get identical
> behavior. There is the initial_delay option which does that.
>

As per the standard IEEE 1588-2019, NO_MECHANISM can be used for both the
cases when we are expecting syntonization as well as when we are
considering the path delay to be 0.

As of now the *"tsproc_update_offset" * looks for a valid *t3 * and
*filtered_delay_valid
*to be True to calculate the offset. If the mentioned condition does not
meet it returns an error and as a result
servo never processes the data and the port never gets into a locked state.  In
this case t3 will always remain 0. "TSPROC_NO_DELAY_MECHANISM" has been
added to overcome this situation,

Thanks,
Devasish  Dey

Vice President

Engineering Product Development | SyncMonk Technologies Pvt Limited
+91-783-8079202
devasish....@syncmonk.net
www.syncmonk.net
367, KPC Layout, Bangalore-560035



>
>
>
> _______________________________________________
> Linuxptp-devel mailing list
> Linuxptp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
>


--
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to